CASSANDRA-20884 - Move JMX classes to the in-jvm-dtest API project (5.0) #4369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbotella
approved these changes
Sep 23, 2025
Contributor
bbotella
left a comment
bbotella
left a comment
There was a problem hiding this comment.
+1
Remember to remove the snapshot from the dependency name once the api is released, and before merging.
JeetKunDoug
force-pushed
the
jmx-to-dtest-api-5.0
branch
2 times, most recently
from
cfb22db to
8185761
Compare
frankgh
reviewed
Oct 23, 2025
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
Looks good in general. There's one change that seem to have snuck in and I think we should revert it
.build/build-resolver.xml
Outdated
| all dependency resolution regardless of it being a -SNAPSHOT lib or not. | ||
| --> | ||
| <!-- <remoterepo id="resolver-apache-snapshot" url="${artifact.remoteRepository.apacheSnapshot}" releases="false" snapshots="true" updates="always" checksums="fail" /> --> | ||
| <!-- <remoterepo id="resolver-apache-snapshot" url="${artifact.remoteRepository.apacheSnapshot}" releases="false" snapshots="true" updates="always" checksums="fail" /> --> |
Contributor
Author
There was a problem hiding this comment.
IntelliJ really likes adding that space because the "close" tag above it is actually out of alignment with the open tag above (I assume on purpose maybe?).
JeetKunDoug
changed the title
JeetKunDoug
force-pushed
the
jmx-to-dtest-api-5.0
branch
from
8185761 to
3a41983
Compare
JeetKunDoug
force-pushed
the
jmx-to-dtest-api-5.0
branch
from
3a41983 to
8755520
Compare
Contributor
Author
|
Resolved with b4dcef7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Cassandra 5.0 update to move JMX test classes to the dtest-api project.
It depends on apache/cassandra-in-jvm-dtest-api#41 and will require a new release of the dtest-api so it is not ready to merge yet, but can be reviewed at this point.